Ssc 1300 wind lifetime mode#1386
Ssc 1300 wind lifetime mode#1386brtietz wants to merge 2 commits intossc_1378_custom_generation_lifetimefrom
Conversation
Coverage Report for CI Build 24285419571Coverage increased (+0.007%) to 56.282%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions101 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
Thanks for flagging this. I grabbed the code from PVWatts, which applies the degradation linearly: Line 378 in 2ffaf57 The code in the released version applies degradation exponentially: Line 1155 in 2ffaf57 Looks like I used the exponential convention for custom generation profile as well: ssc/ssc/cmod_custom_generation.cpp Line 138 in 2ffaf57 Just to confirm/establish a convention here: DC degradation for PV is linear, but for all other models AC degradation is exponential. Is that what we want? (if so I'll want to adjust some version upgrade messaging around the PVWatts changes for this version) |
|
I pulled up some papers to help inform this decision. The curves in https://www.sciencedirect.com/science/article/pii/S0360544225017840 and https://papers.phmsociety.org/index.php/phme/article/download/3328/1939 look pretty linear. ATB assumes that O&M will counteract degradation, which is unhelpful here. @janinefreeman is there an NLR wind person you'd recommend asking about this? |
|
I've messaged a wind person to ask for the right name and I'll send you a Teams message. It does seem weird to me that DC degradation would be linear but it also rings a bell, is there an old issue that might illuminate that decision somewhere? |
Thanks! See #503 for some of the PV background. |
Regarding PV degradation, I did a quick search on the PVPMC Modeling Steps and pvlib websites and did not see mention of annual DC degradation there. |


Pull Request Template
Description
Adds lifetime mode to windpower. In addition to the obvious for loops, required updating the data provider with a rewind function. This reads in the file at the start of the simulation and references arrays, more similar to PV. AI disclosure: Claude Sonnet assisted with the rewind function.
Note that the weather file mode for wind is slower by a linear factor of analysis period length. Open to changing that prior to merging if we prefer a different approach to applying degradation. This would impact year 1 vs lifetime outputs.
Fixes #1300
Corresponding branches and PRs:
SAM PR tbd. Develop of other repos.
Unit Test Impact:
New wind lifetime tests. No other changes expected
Checklist
Reminders- this section can be deleted
[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)