Draft
Conversation
yzhou601
commented
Apr 14, 2026
| supp_staging_program.addLine(" Set #{supp_coil_avail_act.name} = 0") | ||
| supp_staging_program.addLine('Else') # global variable = 1 | ||
| supp_staging_program.addLine(" Set #{supp_coil_avail_act.name} = 1") | ||
| supp_staging_program.addLine(" If (supp_htg_rate_1_ago > 0) && (#{htg_sp_ss.name} + #{living_temp_ss.name} > 0.01)") |
Collaborator
Author
There was a problem hiding this comment.
"+" here doesn't make sense to me, should be "-" instead, likely a typo, likely by me. :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Output variables "Zone Thermostat Heating/Cooling Setpoint Temperature" can be changed by E+ when there's an on-off thermostat, EMS program should use setpoint "Schedule Value" instead to be safe.
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run