-
Notifications
You must be signed in to change notification settings - Fork 5
Reorganization for install with pip or conda #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
d-montgomery
wants to merge
48
commits into
NatLabRockies:main
Choose a base branch
from
d-montgomery:pip-conda
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 36 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
f956998
Reorg for pip
d-montgomery 5ff75aa
Better docs building
d-montgomery 285efe5
Better formatting via fl-format
d-montgomery 16ed541
Update CI
d-montgomery 1f3b7aa
Specify molar vs. mass Cp
d-montgomery e0821b6
Extend title in docs
d-montgomery a623baf
Remove old paths.py
d-montgomery 358abbf
Update MW
d-montgomery 8d527fa
Update installation with pip
d-montgomery 4e90e17
Update installation and docs
d-montgomery 2d434b0
Update to 0.1.1
d-montgomery 3e1c5f5
Format and update docs
d-montgomery 04546b2
Update version for pip
d-montgomery 6cc62bc
Update license for pip
d-montgomery 31ef35b
Update license for pip
d-montgomery b527da9
Potential fix for pull request finding
d-montgomery 30bb2b9
Get version from metadata
d-montgomery b4d18ef
Additional command line utilities
d-montgomery a13fca0
Update README links
d-montgomery 231eda1
Add CI testing for utilities
d-montgomery 755f6da
Add eps2K to API contract
d-montgomery 064f32e
Update file structure in docs
d-montgomery 83a0e5b
Simplify custom fuels and add more CLI plotting
d-montgomery 86d83bf
Format
d-montgomery 17e73b5
Update docs, fix error in decomp for Cycloaromatic-C09
d-montgomery 83cc618
Update baselines after bug in decomp. Update plotting and custom fuel…
d-montgomery 67aee46
Format
d-montgomery 0c5b26c
Add documentation for CLI
d-montgomery 25964d6
Fix error for Jet A
d-montgomery 6275a0b
Add temp converters to API contract
d-montgomery 2da2de7
Break up fuellib/__init__
d-montgomery d890315
BREAKING CHANGES: namespace for convert, utility
d-montgomery bdc8a09
Fix exporter test
d-montgomery 6229179
Update version to v3.0.0a1 after breaking changes
d-montgomery 0cd08f7
Fix docstrings test
d-montgomery 416a0e1
Move dev tools to cli
d-montgomery 052e84c
Apply suggestions from code review
d-montgomery ffe5ac5
Implment suggestions from review.
d-montgomery 16c1763
Consolidate redundant POSF decomposition files
d-montgomery a9855e8
Fix plotting CLI imports - use direct imports instead of re-exports
d-montgomery 6a6742e
Rename to get_fueldata_propsdata - consistent API naming
d-montgomery 6719200
Clean up API exports - use consistent module namespacing
d-montgomery 185ecb5
Remove unused import of k_B and N_A
d-montgomery 4a3f0ce
Simplify API, update docs
d-montgomery 978a386
Apply suggestions from code review
d-montgomery bd043cb
Resolve comments from review
d-montgomery e7c6c0d
Update version for PyPi
d-montgomery cab99c1
Change default export dir for exporters
d-montgomery File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| Contributing to FuelLib | ||
| ======================= | ||
|
|
||
| We welcome contributions! This page covers how to set up your development environment, make changes, and submit pull requests. | ||
|
|
||
| Development Setup | ||
| ----------------- | ||
|
|
||
| Clone the repository and install in editable mode with development dependencies: | ||
|
|
||
| .. code-block:: bash | ||
|
|
||
| git clone https://github.com/NatLabRockies/FuelLib.git | ||
| cd FuelLib | ||
| pip install -e '.[dev]' | ||
|
|
||
| This installs FuelLib with all development tools: | ||
|
|
||
| - **Documentation:** Sphinx, sphinx-rtd-theme, sphinxcontrib-bibtex | ||
| - **Code formatting:** Black | ||
| - **Testing:** pytest | ||
| - **Plotting:** matplotlib | ||
|
|
||
| Optional: Conda Environment | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| To use a specific conda environment: | ||
|
|
||
| .. code-block:: bash | ||
|
|
||
| conda create --name fuellib-env python numpy pandas scipy matplotlib | ||
| conda activate fuellib-env | ||
| pip install -e '.[dev]' | ||
|
|
||
| Contributing Guidelines | ||
| ----------------------- | ||
|
|
||
| New contributions are always welcome! To contribute: | ||
|
|
||
| 1. Fork the main repository on GitHub | ||
| 2. Create a new branch for your feature: ``git checkout -b newFeature`` | ||
| 3. Make your changes and update documentation as needed | ||
| 4. Ensure development dependencies are installed (see Development Setup above) | ||
| 5. Format your code using Black ``fl-format`` | ||
|
|
||
| 6. Run tests to verify your changes. See `.github/workflows/ci.yml` for the most up-to-date list of tests run in CI | ||
| 7. Open a Pull Request (PR) from your fork to the main FuelLib repository | ||
|
|
||
| Building and Viewing Documentation Locally | ||
| ------------------------------------------- | ||
|
|
||
| To build the documentation after installing with ``pip install -e '.[dev]'``: | ||
|
|
||
| .. code-block:: bash | ||
|
|
||
| fl-build-docs | ||
|
|
||
| The built documentation will be in ``docs/_build/html/``. Open ``index.html`` in your browser to view it. | ||
|
|
||
| To clean the build artifacts: | ||
|
|
||
| .. code-block:: bash | ||
|
|
||
| fl-clean-docs |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.