Refactor array-based input code to use key-based input (part 2)#11526
Draft
jasondegraw wants to merge 12 commits intodevelopfrom
Draft
Refactor array-based input code to use key-based input (part 2)#11526jasondegraw wants to merge 12 commits intodevelopfrom
jasondegraw wants to merge 12 commits intodevelopfrom
Conversation
jasondegraw
added
DoNotPublish
|
|
|
|
amirroth
reviewed
Apr 14, 2026
Collaborator
amirroth
left a comment
amirroth
left a comment
There was a problem hiding this comment.
It's about time we did some of this. Thanks @jasondegraw.
| IOStatus); | ||
| if (!Util::SameString(name_to_find, state.dataIPShortCut->cAlphaArgs(1))) { | ||
| for (auto const &modeInstance : modeInstances.value().items()) { | ||
| auto const modeName = Util::makeUPPER(modeInstance.key()); |
Collaborator
There was a problem hiding this comment.
I'm not a fan of using auto for std::string, but in your defense, at least you are using auto and auto & correctly. 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This is a follow-up PR that replaces array-based input code with key-based input code. The first one went well, so full speed ahead. No thought went into the files that were chosen. This will be in draft while regressions get worked out.
Pull Request Author
Reviewer