Apply human readable text to autosizing strings#11492
Apply human readable text to autosizing strings#11492
Conversation
|
5ZoneAirCooledDemandLimiting json file format result in this branch. Note snake_case column headings: 
idf result, note Camel Case column headings: 
|
|
Background: When the component sizing routines were consolidated into the sizer functions there were some components that used one string and other components that used a similar string. To reduce diffs the overrideSizingString function was implemented. This was used to 1) unify textual strings as Camel case, 2) used to override the snake_case used in json (same as 1 really), and 3) keep the look of the tables the same regardless of idf or json format using Camel Case text. The sizing string is passed via a text string or a field name string depending on which source file is setting up that string. For the json file format, the FieldNames string is of course snake_case, without units. Hopefully there is a clean path forward to fix all other issues caused by this specific code. idf: json: |
| state.dataSize->DataCapacityUsedForSizing = waterCoil.DesWaterHeatingCoilRate; | ||
| } | ||
| waterCoil.DesTotWaterCoilLoad = waterCoil.DesWaterHeatingCoilRate; | ||
| state.dataSize->DataCapacityUsedForSizing = waterCoil.DesWaterHeatingCoilRate; |
There was a problem hiding this comment.
I tried to reduce this further and call the same sizer function for both coil locations, airloop and zone, but this doesn't work for system coils and the autosized result is 0:
WaterHeaterCapacitySizing.cc:
} else if (this->curSysNum > 0) {
if (!this->wasAutoSized && !this->sizingDesRunThisAirSys) {
this->autoSizedValue = _originalValue;
} else {
// not implemented for air loop equipment
}
There was a problem hiding this comment.
If I call the HeatingCapacity sizer, without overriding SizingString, I get a good table but the column heading is nominal_capacity, which is the field name for non-water coil types.
Coil:Heating:Water,
N3 , \field Rated Capacity
Coil:Heating:Electric,
N2 , \field Nominal Capacity
HeatingCapacitySizing.cc:
if (this->overrideSizeString) {
if (this->isEpJSON) {
this->sizingString = "nominal_capacity [W]";
}
}
…into 11477-water-coil-sizing-strings
rraustad
changed the title
|
|
|
|
|
|
File with diffs, RefBldgMediumOfficeNew2004_Chicago_epJSON Example eio diff: Example table diff (now has Camel Case column headings): develop: 
this branch: 
|
|
@mitchute @joseph-robertson these changes address a lot of the eio and table issues with snake_case text. I am changing the description to show that this branch fixes the issue and other issues can be corrected when found. |
|
|
|
|
4 participants
Pull request overview
Description of the purpose of this PR
Component sizing strings should be uniform between for idf or json formats, whichever are used.
Pull Request Author
Reviewer