Skip to content

Crawl4AI changed API#407

Merged
castelao merged 4 commits intomainfrom
fix/tox_202604
Apr 12, 2026
Merged

Crawl4AI changed API#407
castelao merged 4 commits intomainfrom
fix/tox_202604

Conversation

@castelao
Copy link
Copy Markdown
Member

@castelao castelao commented Apr 12, 2026

We depend on ELM which depends on Crawl4AI. Crawl4AI-0.8.5 changed its API breaking compatibility. Let's hold on <0.8.5 until ELM is updated.

This PR will fix the recent failures in our Github-actions only for tox tasks since everything else relies on pixi thus have a well defined environment. Which is a real world argument for the recent discussions on keep using tox here.

We depend on ELM which depends on Crawl4AI. Crawl4AI-0.8.5 changed its
API breaking compatibility. Let's hold on <0.8.5 until ELM is updated.
@castelao castelao self-assigned this Apr 12, 2026
@castelao castelao added bugfix Fixed a known bug p-critical Priority: critical labels Apr 12, 2026
Copilot AI review requested due to automatic review settings April 12, 2026 18:00
@castelao castelao requested a review from ppinchuk as a code owner April 12, 2026 18:00
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.57%. Comparing base (daac6d4) to head (cafb8fe).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   55.60%   55.57%   -0.04%     
==========================================
  Files          61       61              
  Lines        5681     5681              
  Branches      531      531              
==========================================
- Hits         3159     3157       -2     
- Misses       2475     2476       +1     
- Partials       47       48       +1     
Flag Coverage Δ
unittests 55.57% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins crawl4ai to avoid the breaking API changes introduced in crawl4ai==0.8.5, maintaining compatibility with the current nlr-elm dependency chain.

Changes:

  • Add a direct crawl4ai version constraint (<0.8.5) to the project’s runtime dependencies.
  • Regenerate/update pixi.lock so the resolved environment reflects the new constraint.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
pyproject.toml Adds an explicit crawl4ai dependency range intended to block 0.8.5+.
pixi.lock Updates the lockfile to include the new crawl4ai constraint in requires_dist.

Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
@castelao
Copy link
Copy Markdown
Member Author

@ppinchuk , ready for review.

@castelao castelao merged commit 4c06566 into main Apr 12, 2026
26 checks passed
@castelao castelao deleted the fix/tox_202604 branch April 12, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixed a known bug p-critical Priority: critical

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants