Merged
Conversation
We depend on ELM which depends on Crawl4AI. Crawl4AI-0.8.5 changed its API breaking compatibility. Let's hold on <0.8.5 until ELM is updated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
==========================================
- Coverage 55.60% 55.57% -0.04%
==========================================
Files 61 61
Lines 5681 5681
Branches 531 531
==========================================
- Hits 3159 3157 -2
- Misses 2475 2476 +1
- Partials 47 48 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Pins crawl4ai to avoid the breaking API changes introduced in crawl4ai==0.8.5, maintaining compatibility with the current nlr-elm dependency chain.
Changes:
- Add a direct
crawl4aiversion constraint (<0.8.5) to the project’s runtime dependencies. - Regenerate/update
pixi.lockso the resolved environment reflects the new constraint.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pyproject.toml |
Adds an explicit crawl4ai dependency range intended to block 0.8.5+. |
pixi.lock |
Updates the lockfile to include the new crawl4ai constraint in requires_dist. |
Member
Author
|
@ppinchuk , ready for review. |
ppinchuk
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We depend on ELM which depends on Crawl4AI. Crawl4AI-0.8.5 changed its API breaking compatibility. Let's hold on <0.8.5 until ELM is updated.
This PR will fix the recent failures in our Github-actions only for
toxtasks since everything else relies onpixithus have a well defined environment. Which is a real world argument for the recent discussions on keep usingtoxhere.