Update for remote tags which have 'refs/tags/' in front of the tag name#12
Open
joepjoosten wants to merge 4 commits intoNasdaq:masterfrom
Open
Update for remote tags which have 'refs/tags/' in front of the tag name#12joepjoosten wants to merge 4 commits intoNasdaq:masterfrom
joepjoosten wants to merge 4 commits intoNasdaq:masterfrom
Conversation
deepy
suggested changes
Apr 13, 2018
| testParseVersion("1.2.3-SNAPSHOT", [1,2,3,"SNAPSHOT"]); | ||
| } | ||
| void testParseVersion12_34_56_rc78() { | ||
| testParseVersion("12.34.56-rc78", [12,34,56,"rc78"]); |
Contributor
There was a problem hiding this comment.
The test name doesn't match the other tests, please restore a copy of the old one or rename the test
Contributor
|
Hi @joepjoosten, thank you for your contribution, it looks great! There's just this one little minor thing before we can merge it. |
Author
|
Hi @deepy. Fix the duplicate test that i wrongfully copy / pasted.... |
Author
|
@deepy and now it also returns the version without "refs/tags" so that version can be used correctly |
deepy
approved these changes
Apr 18, 2018
Contributor
|
Fantastic :-) Have you signed the CLA? https://www.cinnober.com/cla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using this in with continuous integration, the cloned git repo only had the tags from the remote repo, and when doing a git describe, the tags contain 'refs/tags/' in front of the tag name.
This change to the regex fixes this.