ci: adopt the shared PR checks workflow; split lint and format - #124
Merged
Conversation
Fourth repo onto the shared workflow in Nano-Collective/.github, after get-md, sentinel and prompt-scrubber. Two things had to change first. nanotune was the only repo where test:lint ran `biome check .` — which is what every other repo calls test:format — and it had no test:format at all. The shared workflow runs both as separate blocking checks, so the scripts now match the org convention: test:lint is `biome lint .`, and test:format is the formatter-only biome ci invocation prompt-scrubber and nanoterm already use. Same coverage, split across the two checks it is meant to be split across. Coverage is 71.46% against an org floor of 80. Rather than leave a permanently red check on all 7 open PRs — punishing contributors for pre-existing debt — the floor is pinned at 71 and fail-on-drop does the work: coverage cannot regress from here. The gap closes deliberately, tracked in #123, and nanotune stays out of the org quality ruleset until it clears 80. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014WoygKgfq3ahXinVVHqjA8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth repo onto the shared
pr-checksworkflow inNano-Collective/.github, after get-md, sentinel and prompt-scrubber.Two blockers had to clear first
1. lint and format were the same script
nanotunewas the only repo wheretest:lintranbiome check .— which is what every other repo callstest:format— and it had notest:formatat all:test:lintbiome lint .biome check .test:formatThe shared workflow runs Linting and Format Checks as separate blocking jobs, so this had to be split.
test:lintis nowbiome lint .;test:formatis the formatter-onlybiome ciinvocation that prompt-scrubber and nanoterm already use. Same coverage, split across the two checks it is meant to be split across. Both verified passing locally, along with types and knip.2. Coverage is below the org floor
71.46% against a standard of 80. Rather than leave a permanently red check on all 7 open pull requests — punishing contributors for pre-existing debt and training everyone to ignore CI — the floor is pinned just under current coverage:
fail-on-drop does the real work from today: the baseline is read from the committed coverage badge on
main, so any PR that lowers coverage fails. Coverage cannot regress; the gap to 80 closes deliberately rather than drifting.Tracked in #123.
nanotunestays out of the org quality ruleset until the input can be deleted.What it gains
Blocking — Linting, Type Checks, Format Checks, Unused Dependencies, Unit Tests & Coverage Analysis, Verify Build.
Advisory — Package Audit Analysis, Semgrep Security Scan, CodeQL Security Analysis. These report but never fail the PR, since they depend on upstream advisory feeds.