Skip to content

feat(connections): allow patching connection-level webhook_url#6739

Merged
kaposke merged 3 commits into
masterfrom
gui/nan-6208-add-endpoint-to-edit-connection-level-webhook-url
Jul 13, 2026
Merged

feat(connections): allow patching connection-level webhook_url#6739
kaposke merged 3 commits into
masterfrom
gui/nan-6208-add-endpoint-to-edit-connection-level-webhook-url

Conversation

@kaposke

@kaposke kaposke commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Extend public PATCH /connections/:connectionId to accept webhook_url (set or clear the connection-level override)
  • Add private PATCH /api/v1/connections/:connectionId with the same body, sharing handler logic with the public route
  • Add integration coverage for both surfaces

Review in cubic

Extend public and private PATCH /connections to set or clear webhook_url,
sharing handler logic between both surfaces.

Co-authored-by: Cursor <cursoragent@cursor.com>
@linear-code

linear-code Bot commented Jul 10, 2026

Copy link
Copy Markdown

NAN-6208

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Co-authored-by: Cursor <cursoragent@cursor.com>
@kaposke kaposke requested a review from a team July 10, 2026 18:19
@mintlify

mintlify Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
nango 🟢 Ready View Preview Jul 10, 2026, 6:30 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Comment thread packages/server/lib/controllers/shared/connections/patchConnection.ts Outdated
Comment thread packages/types/lib/connection/api/get.ts Outdated
Return Result from the end_user transaction instead of headersSent,
drop redundant trim, and include invalid_body in the endpoint error types.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kaposke kaposke added this pull request to the merge queue Jul 13, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 13, 2026
@kaposke kaposke added this pull request to the merge queue Jul 13, 2026
Merged via the queue into master with commit 0478a92 Jul 13, 2026
34 checks passed
@kaposke kaposke deleted the gui/nan-6208-add-endpoint-to-edit-connection-level-webhook-url branch July 13, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants