feat(integrations): add support for sage-member#6717
Open
hassan254-prog wants to merge 2 commits into
Open
Conversation
hassan254-prog
temporarily deployed
to
development
GitHub Actions
Inactive
Contributor
Preview Deploy
|
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 14 files
Confidence score: 5/5
- Safe to merge after the addressed issues were fixed.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
hassan254-prog
temporarily deployed
to
development
GitHub Actions
Inactive
TBonnin
reviewed
Jul 10, 2026
| - e-commerce | ||
| auth_mode: API_KEY | ||
| proxy: | ||
| base_url: https://www.promoplace.com/ws/ws.dll |
Collaborator
There was a problem hiding this comment.
that doesn't look like SAGE related?
| continue; | ||
| } | ||
| const nested: Record<string, string> = {}; | ||
| for (const [nestedKey, nestedValue] of Object.entries(value)) { |
Collaborator
There was a problem hiding this comment.
what if there is more than one level of nesting?
| if (existing instanceof URLSearchParams) { | ||
| for (const [key, value] of Object.entries(injected)) existing.append(key, value); | ||
| for (const [key, value] of Object.entries(injected)) { | ||
| appendInjectedEntry((k, v) => existing.append(k, v), key, value); |
Collaborator
There was a problem hiding this comment.
do we have proper testing for all the existing code paths that are being affected by this change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the problem and your solution