-
Notifications
You must be signed in to change notification settings - Fork 42
refactor: move gen logic to frontend #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
0fe3e16
重构合并
NangInShell 5649b82
重构合并
NangInShell 0079f80
重构合并
NangInShell 2256100
重构合并
NangInShell 2dd1f59
重构
NangInShell 1dcd553
重构
NangInShell 239abba
Merge remote-tracking branch 'nang/n-br'
Tohrusky c830170
refactor: rename
Tohrusky e99816a
refactor: rename
Tohrusky 1fc4d67
refactor: shit!
Tohrusky 6a5858a
fix: str
Tohrusky edcd7a1
del: unused files
Tohrusky e940ed9
fix: router name
Tohrusky 9d16f0a
fix: router name
Tohrusky d7ab78e
fix: vpy gen
Tohrusky 43ca015
fix: vpy gen
Tohrusky 3bc35bc
fix: path.normalize
Tohrusky 5f4e29c
fix: mp4 -> .mp4
Tohrusky 9923724
fix: UnderlineCase -> CamelCase
Tohrusky c7b0523
fix: cache
Tohrusky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| import type { TaskConfig } from '@shared/type/taskConfig' | ||
| import path from 'node:path' | ||
| import { app } from 'electron' | ||
|
|
||
|
|
@@ -30,27 +31,23 @@ export function getExecPath(): { vspipe: string, ffmpeg: string, ffprobe: string | |
|
|
||
| /** | ||
| * 获取 VSET-core 中的额外超分模型文件夹路径 | ||
| * @returns {string} 额外超分模型文件夹路径 | ||
| */ | ||
| export function getExtraSRModelPath(): string { | ||
| return path.join(getCorePath(), 'vs-coreplugins', 'models', 'VSET_ExtraSrModel') | ||
| } | ||
|
|
||
| /** | ||
| * 获取 VSET 生成的设置文件路径 | ||
| * 暂时存放在 config_json.outputfolder 目录下 | ||
| * @param config_json | ||
| * 暂时存放在 outputfolder 目录下 | ||
| */ | ||
| export function getGenSettingsPath(config_json): string { | ||
| return path.join(config_json.outputfolder, 'setting.json') | ||
| export function getGenSettingsPath(taskConfig: TaskConfig): string { | ||
| return path.join(taskConfig.outputFolder, 'setting.json') | ||
| } | ||
|
|
||
| /** | ||
| * 获取 VSET 生成的 vpy 文件路径 | ||
| * 暂时存放在 config_json.outputfolder 目录下 | ||
| * @param config_json | ||
| * @param base_name 生成的 vpy 文件名(不含扩展名) | ||
| * 暂时存放在 outputfolder 目录下 | ||
| */ | ||
|
Comment on lines
47
to
50
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| export function getGenVpyPath(config_json, base_name: string): string { | ||
| return path.join(config_json.outputfolder, `${base_name}.vpy`) | ||
| export function getGenVpyPath(taskConfig: TaskConfig, baseName: string): string { | ||
| return path.join(taskConfig.outputFolder, `${baseName}.vpy`) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSDoc comments for these functions have been simplified, but the
@paramtags were removed. This is a regression in documentation. It would be beneficial to restore them to clearly document the function parameters and their types.