fix: Add count guard to eventarc_pubsub IAM resource#99
Closed
miguelpuiggarcia wants to merge 1 commit into
Closed
fix: Add count guard to eventarc_pubsub IAM resource#99miguelpuiggarcia wants to merge 1 commit into
miguelpuiggarcia wants to merge 1 commit into
Conversation
The eventarc_pubsub resource was unconditionally created (no count guard), while its sibling eventarc_cloud_run already had one. This caused a Terraform dependency cycle when the cloud-run-v2 module was used with create_trigger=true, because the unconditional data.google_project.current lookup created a circular reference through the trigger_provision module. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eventarc_pubsubresource ingcp/cloud-run-v2/main.tfwas unconditionally created (nocountguard), while its siblingeventarc_cloud_runresource already hadcount = length(var.eventarc_triggers) > 0 ? 1 : 0create_trigger=true, because the unconditionaldata.google_project.currentlookup created a circular reference through thetrigger_provisionsub-modulecountguard toeventarc_pubsub, matching the existing pattern oneventarc_cloud_runImpact
This is blocking production Terraform deployments for the AI project (
prod-ai-f05cb557).Test plan
terraform planno longer produces a cycle error🤖 Generated with Claude Code