Skip to content

feat: adds generic event flag for cloud functions #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rafeeJ wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: adds generic event flag for cloud functions #63

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1032f17
feat: adds generic event flag
Apr 9, 2024
fbc6463
feat: missing local decleration
Apr 9, 2024
2d851f0
feat: add dummy storage trigger function
Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
.DS_Store
.DS_Store
.idea/
4 changes: 3 additions & 1 deletion gcp/cloud-function-gen2/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ locals {
default_runtime = "go116"
}
}[var.function_type]

is_generic_event_type = var.event_type != "PUBSUB" && var.event_type != "STORAGE"
}

/******************************************
Expand Down Expand Up @@ -97,7 +99,7 @@ resource "google_cloudfunctions2_function" "function" {
}

dynamic "event_trigger" {
for_each = var.event_trigger != null ? [var.event_trigger] : []
for_each = is_generic_event_type ? [var.event_trigger] : []
content {
trigger_region = var.region
event_type = event_trigger.value["event_type"]
Expand Down