fix(cloud-run-v2): use custom service account for the Cloud Run service, not just the EventArc trigger#104
Merged
Merged
Conversation
hu86
changed the title
MatteoMantovani78
approved these changes
Apr 23, 2026
MatteoMantovani78
left a comment
MatteoMantovani78
left a comment
There was a problem hiding this comment.
Is this the fix Lewis proposed? good work
lewcinho
approved these changes
Apr 24, 2026
miguelpuiggarcia
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like Service Account specified in cloud_run_service_account is not actually used for the Cloud Run.
This PR is to fix this. But to maintain existing behaviour, a flag use_custom_service_account is added. When this flag is set to true, the Cloud Run will run as cloud_run_service_account instead of the default compute SA.