Skip to content

feat: add approval_required variable to cloud-function-gen2 module #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harrison-carter merged 1 commit into from
Mar 23, 2026
Merged

feat: add approval_required variable to cloud-function-gen2 module #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gcp/cloud-function-gen2/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ module "trigger_provision" {
name = "function-${var.function_name}-provision"
description = "Provision ${var.function_name} Service (CI/CD)"
source = "../cloud-cloudbuild-trigger"
approval_required = var.approval_required
trigger_service_account = var.trigger_service_account
location = var.location
filename = var.function_path == "" ? "services/${var.service_name}/functions/${var.function_name}/cloudbuild.yaml" : "${var.function_path}/cloudbuild.yaml"
Expand Down
6 changes: 6 additions & 0 deletions gcp/cloud-function-gen2/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,3 +203,9 @@ variable "node_version" {
description = "Default Node.js runtime version for deployed functions"
default = "nodejs16"
}

variable "approval_required" {
type = bool
default = false
description = "If true, Cloud Build trigger will require manual approval before executing."
}
Loading