feat: add approval_required config to Cloud Build triggers#101
Merged
harrison-carter merged 2 commits intoMar 19, 2026
Conversation
- Add `approval_required` boolean variable (defaults to `false`) - Use a dynamic `approval_config` block so it's only included when approval is required
harrison-carter
force-pushed
the
feat/add-approval-config-to-cloudbuild-triggers
branch
from
076cd61 to
31547c4
Compare
jbadavis
reviewed
Mar 19, 2026
- Add `approval_required` variable to the cloud-run-v2 module and forward it to the trigger provision submodule
harrison-carter
force-pushed
the
feat/add-approval-config-to-cloudbuild-triggers
branch
from
31547c4 to
235e367
Compare
jbadavis
approved these changes
Mar 19, 2026
|
🎉 This PR is included in version 1.71.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nandosuk.atlassian.net/browse/SRMD-6983
Summary
approval_requiredvariable to thecloud-cloudbuild-triggermodule, which uses a dynamicapproval_configblock to optionally require manual approval before builds executeapproval_requiredvariable through thecloud-run-v2module so consumers can enable approval gating without reaching into the trigger submodule directlyfalseso existing usage is unaffectedTest plan
terraform planwithapproval_required = false(default) produces no diff on existing triggersterraform planwithapproval_required = trueadds theapproval_configblock as expectedcloud-run-v2tocloud-cloudbuild-trigger