[Feat] 보관함 캘린더 구현 #212
Merged
[Feat] 보관함 캘린더 구현 #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seokki-Kwon
approved these changes
Nov 12, 2024
FpRaArNkK
approved these changes
Nov 12, 2024
Comment on lines
+26
to
+28
| return "/calendar/\(ym.year)-\(String(format: "%02d", ym.month))" | ||
| case .getDiaryByDate(let ymd): | ||
| return "/date/\(ymd.year)-\(String(format: "%02d", ymd.month))-\(String(format: "%02d", ymd.day))" |
There was a problem hiding this comment.
해당 포맷의 경우는 따로 유지보수하기 편하게 String Extension이나 ymd의 함수로 만들어 놓으면 좋을 것 같아보여요!
Comment on lines
+148
to
+153
| .clipShape(RoundedCorners(radius: 15, corners: [.topLeft, .topRight])) | ||
| .shadow(color: .black.opacity(0.15), radius: 12, x: 0, y: -5) | ||
| .mask { | ||
| // 상단에만 shadow를 주기 위함 | ||
| Rectangle().padding(.top, -20) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Description
Requirements for Review
라이브러리를 뜯어봐서 디버깅이 필요해보입니다.