Skip to content

fix(ci): repair vibecoder workflow templates #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nadav011 merged 1 commit into from
Mar 29, 2026
Merged

fix(ci): repair vibecoder workflow templates #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:


- name: Install dependencies
run: ppnpm install --frozen-lockfile
run: pnpm install --frozen-lockfile
Comment on lines 27 to +28
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm install --frozen-lockfile will fail when pnpm-lock.yaml is missing or out of date. This repo currently has package-lock.json but no pnpm-lock.yaml, so the CI job is still expected to error. Either commit a generated pnpm-lock.yaml (and keep it updated) or switch the workflow install/lint/typecheck steps to use npm (npm ci / npm run ...) to match the tracked lockfile.

Copilot uses AI. Check for mistakes.

- name: Lint
run: pnpm run lint
Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:
name: CI Gate
runs-on: [self-hosted, linux, x64, pop-os]
if: always()
needs: [push, pull_request, group, cancel-in-progress, lint-typecheck, semgrep, gitleaks, trivy]
needs: [lint-typecheck, semgrep, gitleaks, trivy]
steps:
- name: Evaluate
run: |
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/trivy-autofix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,12 @@ jobs:
echo "CVEs found: $COUNT"

- name: Add Node.js (fnm) to PATH
if: steps.check.outputs.count != '0'
run: echo "$HOME/.local/share/fnm/node-versions/v24.14.0/installation/bin" >> $GITHUB_PATH

- name: Enable pnpm via corepack
run: corepack enable pnpm

if: steps.check.outputs.count != '0'
with:
node-version: "24.14.0"
cache: 'npm'
run: corepack enable pnpm
Comment on lines 47 to +49
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow enables pnpm but never runs an install step after modifying package.json. The PR created by create-pull-request will likely include only package.json changes, leaving the lockfile unchanged and causing CI failures (e.g., frozen lockfile / lockfile integrity checks) and potentially not actually resolving CVEs. Add a step to regenerate and commit the appropriate lockfile (pnpm-lock.yaml or package-lock.json) after applying overrides, and ideally verify the fix with an install.

Copilot uses AI. Check for mistakes.

- name: Auto-fix CVEs via npm overrides
if: steps.check.outputs.count != '0'
Expand Down
Loading