Skip to content

ISW-5483: alignment of label element#1962

Open
bigfishdesign13 wants to merge 3 commits intodevelopmentfrom
ISW-5483/multiselectgroup-label-spacing
Open

ISW-5483: alignment of label element#1962
bigfishdesign13 wants to merge 3 commits intodevelopmentfrom
ISW-5483/multiselectgroup-label-spacing

Conversation

@bigfishdesign13
Copy link
Copy Markdown
Collaborator

@bigfishdesign13 bigfishdesign13 commented Mar 16, 2026

Fixes JIRA ticket ISW-5483

This PR does the following:

  • Updated the styles on the Label component to improve text alignemnt. This update also updates the styles for the label element in the FeedbackBox, NewsletterSignup, Select, Slider, and TextInput components.
  • Removed the DatePicker component from the Form component stories.
  • Added new examples on Form component stories to allow for alignment testing.

How has this been tested?

  • local Storybook
  • unit tests

Accessibility concerns or updates

  • n/a

Accessibility Checklist

  • Checked Storybook's "Accessibility" tab for color contrast and other issues.
  • The feature works with keyboard inputs including tabbing back and forward and pressing space, enter, arrow, and esc keys.
  • For hidden text or when aria-live is used, a screenreader was used to verify the text is read.
  • For features that involve UI updates and focusing on DOM refs, focus management was reviewed.
  • The feature works when the page is zoomed in to 200% and 400%.

Open Questions

Checklist:

  • I have updated the Storybook documentation and changelog accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nypl-design-system Ready Ready Preview, Comment Apr 1, 2026 2:19pm

Request Review

@bigfishdesign13 bigfishdesign13 added the Needs review Pull requests that are ready for peer review. label Mar 16, 2026
@EdwinGuzman EdwinGuzman added DON’T MERGE YET When somethign has been approved, but should not be merged just yet. On hold Pull requests that have been put on the back-burner for the moment. labels Mar 31, 2026
@bigfishdesign13 bigfishdesign13 removed the Needs review Pull requests that are ready for peer review. label Apr 1, 2026
@bigfishdesign13
Copy link
Copy Markdown
Collaborator Author

This PR addresses an update that should be addressed in the next major release. The update is not being released now because it introduces a visual breaking change that could require significant development and QA to address. This PR can be used as a reference for the next major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DON’T MERGE YET When somethign has been approved, but should not be merged just yet. On hold Pull requests that have been put on the back-burner for the moment. POC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants