Moves chemist::dsl to utilities::dsl #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jwaldrop107
approved these changes
Dec 4, 2024
Member
jwaldrop107
left a comment
jwaldrop107
left a comment
There was a problem hiding this comment.
LGTM, but this typedef will need to be updated in addition to the changes in NWChemEx/Chemist#438.
Member
|
🚀 [bumpr] Bumped! New version:v0.1.21 Changes:v0.1.20...v0.1.21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
No
Description
The generic DSL layer that currently lives in Chemist is useful for writing DSLs in other libraries as well (notably TensorWrapper). To that end I have moved it to utilities.
TODOs
None in utilities, though PRs for chemist are incoming.