Skip to content

Conversation

@zachcran
Copy link
Contributor

@zachcran zachcran commented May 12, 2025

Is this pull request associated with an issue(s)?

No.

Description

CMaize uses find_package() in Config search mode to detect an installed version of a dependency. find_package in this mode looks for files named <PackageName>Config.cmake (case sensitive) or <lowercasePackageName>-config.cmake (also case sensitive, but lowercase). CMaize, by default, uses the dependency name provided to cmaize_find_or_build_dependency, which is eigen, but the Eigen package generates this file as Eigen3Config.cmake.

Solution

Use the optional NAME field in cmaize_find_or_build_dependency to set the correct find_package name to Eigen3.

TODOs

@zachcran zachcran self-assigned this May 12, 2025
@zachcran zachcran added the bug-fix Fixes a bug with a PR label May 12, 2025
@zachcran zachcran marked this pull request as draft May 12, 2025 19:49
@zachcran
Copy link
Contributor Author

zachcran commented May 12, 2025

Marked as draft until the issues in CMaize and sigma are resolved.

@zachcran zachcran marked this pull request as ready for review July 7, 2025 15:53
@zachcran
Copy link
Contributor Author

zachcran commented Jul 7, 2025

@ryanmrichard Can you rerun the failed test, please? There have been many changes since then that hopefully will fix the errors.

@zachcran zachcran merged commit 283471f into master Jul 7, 2025
9 checks passed
@zachcran zachcran deleted the eigen-install-detection branch July 7, 2025 16:27
@jwaldrop107
Copy link
Member

🚀 [bumpr] Bumped!
New version:v0.0.62
Changes:v0.0.61...v0.0.62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix Fixes a bug with a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants