Skip to content

Conversation

@jlheflin
Copy link
Contributor

@jlheflin jlheflin commented May 6, 2025

Is this pull request associated with an issue(s)?
Undocumented issue for the install procedure. When installing, the install is unable to find "config.hpp", which fails the install.

Description
Removes the install statement in CMakeLists.txt for config.hpp

TODOs
Should be r2g after reviw

@jlheflin jlheflin requested a review from ryanmrichard May 6, 2025 22:00
Copy link
Contributor

@zachcran zachcran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just came across the same issue while setting up the Spack package for this repo, and implemented the same solution on my local system to fix this. I can verify that this makes the install work.

@zachcran
Copy link
Contributor

@jlheflin Is this PR r2g? If so, mark it as "Ready for review" so that it can be merged, please.

@jlheflin jlheflin marked this pull request as ready for review May 12, 2025 00:47
@jlheflin jlheflin merged commit 2d36a94 into master May 12, 2025
9 checks passed
@jlheflin jlheflin deleted the remove_config_install branch May 12, 2025 00:48
@jwaldrop107
Copy link
Member

🚀 [bumpr] Bumped!
New version:v0.0.56
Changes:v0.0.55...v0.0.56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants