Buffer API update #209
Merged
Buffer API update #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 22, 2025
Member
ryanmrichard
left a comment
ryanmrichard
left a comment
There was a problem hiding this comment.
Looks great! Just two minor questions.
ryanmrichard
approved these changes
Apr 22, 2025
Member
Author
|
🚀 [bumpr] Bumped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
No
Description
This PR changes the API used to interact with the
ContiguousandEigenbuffers, moving towards explicit getters and setters for accessing data.get_elem/set_elemuses coordinate indices, whileget_data/set_datauses ordinal indices (overloading wasn't used for these because the index types make the signatures ambiguous). A read-only pointer to the underlying data is accessible withget_immutable_data, while a read/write pointer is available withget_mutable_data.The
get_mutable_datafunction should be used with care because of the second part of this PR, which is switching to a hash-based equality check for buffers. Having mutable pointers to the underlying data around means it is unfeasible to track changes within the tensor, so usingget_mutable_dataturns off any attempt to store the hash of the current state and requires recalculation each time equality is checked. Otherwise, the hash will only be updated when a non-const method is called (or if it's the first time it's being checked).