Eigen Tensor Comparison #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmrichard
approved these changes
Apr 10, 2025
Member
Author
|
🚀 [bumpr] Bumped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current method of comparing
EigenTensors fails in certain cases. Currently, the difference between two tensors is summed and compared to zero. In general, this method has an issue when the differences of the individual terms are not zero but their sum is zero (as was happening in the changed unit test). Specifically forsigma::uncertainvalues, the comparison toFloatType(0.0)would almost never return true since the difference values still track error sources whose contributions have been negated up to that point. This PR updates the comparison operator forEigenTensorto an element-wise boolean comparison and then reducing those values.