-
Notifications
You must be signed in to change notification settings - Fork 1
Custom contraction #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom contraction #195
Conversation
|
@jwaldrop107 I tested this with your sigma PR and it seems to work (as long as the |
|
After thinking about it some more this morning I should move this under the |
|
@jwaldrop107 once this passes CI this should be ready. FWIW, I tried this PR with your Sigma branch and your Sigma changes seem to work now. Point being I'm relatively confident it's a bug in Eigen's contraction routine that was causing the error. |
jwaldrop107
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works when I tested in combination with the add_sigma branch. LGTM.
|
🚀 [bumpr] Bumped! New version:v0.0.41 Changes:v0.0.40...v0.0.41 |
Is this pull request associated with an issue(s)?
No
Description
Implements a custom contraction kernel for Eigen Tensor.
TODOs
None. R2g if it passes CI.