Skip to content

Conversation

@ryanmrichard
Copy link
Member

Is this pull request associated with an issue(s)?
No

Description
Implements a custom contraction kernel for Eigen Tensor.

TODOs
None. R2g if it passes CI.

@ryanmrichard ryanmrichard self-assigned this Feb 5, 2025
@ryanmrichard
Copy link
Member Author

@jwaldrop107 I tested this with your sigma PR and it seems to work (as long as the eigen_contraction.cpp test doesn't use Sigma since this PR bypasses that function).

@ryanmrichard ryanmrichard marked this pull request as draft February 5, 2025 14:32
@ryanmrichard
Copy link
Member Author

After thinking about it some more this morning I should move this under the eigen_contraction API. In particular, I'm not sure this is actually getting thoroughly tested because I think proving that contraction works fell to that function. I'll work on making that change today.

@ryanmrichard ryanmrichard marked this pull request as ready for review February 6, 2025 15:58
@ryanmrichard
Copy link
Member Author

@jwaldrop107 once this passes CI this should be ready. FWIW, I tried this PR with your Sigma branch and your Sigma changes seem to work now. Point being I'm relatively confident it's a bug in Eigen's contraction routine that was causing the error.

Copy link
Member

@jwaldrop107 jwaldrop107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works when I tested in combination with the add_sigma branch. LGTM.

@jwaldrop107 jwaldrop107 merged commit d51768f into master Feb 6, 2025
5 checks passed
@jwaldrop107 jwaldrop107 deleted the custom_contraction branch February 6, 2025 17:17
@jwaldrop107
Copy link
Member

🚀 [bumpr] Bumped! New version:v0.0.41 Changes:v0.0.40...v0.0.41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants