Pyberny prop update #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwaldrop107
reviewed
Apr 23, 2025
Member
jwaldrop107
left a comment
jwaldrop107
left a comment
There was a problem hiding this comment.
Couple of small things. Otherwise, this looks on track.
ryanmrichard
requested changes
May 5, 2025
ryanmrichard
approved these changes
May 5, 2025
jwaldrop107
approved these changes
May 5, 2025
Member
|
🚀 [bumpr] Bumped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
No
Description
This pull requests seeks to replace the current property type of TotalEnergy in the PyBerny module with TotalEnergyNuclearOptimization.
TODOs
The test needs to be updated to include the point set changes that occur after the module runs. Currently it only checks the energy.