-
Notifications
You must be signed in to change notification settings - Fork 0
__init__.py adding lenard-jones potential #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding the lenard-jones potential
…inal file to lj_potential.py
…r into fcuantico-patch-1
src/python/structurefinder/lj_potential/lennard_jones_potential_module.py
Outdated
Show resolved
Hide resolved
src/python/structurefinder/lj_potential/lennard_jones_potential_module.py
Outdated
Show resolved
Hide resolved
tests/python/unit_tests/test_lennard_jones_potential/test_LJ_potential.py
Outdated
Show resolved
Hide resolved
tests/python/unit_tests/test_lennard_jones_potential/test_LJ_potential.py
Show resolved
Hide resolved
ryanmrichard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it's basically r2g.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the tests are passing as well as they're going to for now. I don't think the clang failure is resolvable at this time. We can probably go ahead and merge this.
|
@jwaldrop107 the error: requires casting the tensor to a numpy array and printing the element. Similarly, should be fixable by casting the object to a numpy array and then comparing the element to -1.0. So I'd advocate for fixing the tests before merging. |
|
@ryanmrichard The first error is the same error that @jlheflin's change (which is to cast the offending |
tests/python/unit_tests/test_lennard_jones_potential/test_lennard_jones_potential.py
Outdated
Show resolved
Hide resolved
…ard_jones_potential.py
|
@jwaldrop107 If my suggestion fixes the error, then that should also fix FriendZone. I'm not sure what's going on with the logging issue, but PyBerny should not be seeing a tensorwrapper tensor. |
|
@ryanmrichard, NWChemEx/TensorWrapper#207 has this passing now. |
|
🚀 [bumpr] Bumped! New version:v0.0.2 Changes:v0.0.1...v0.0.2 |
Adding the lenard-jones potential
Is this pull request associated with an issue(s)?
Please list issues associated with this pull request, including closing words
as appropriate.
Description
Describe what this pull request will accomplish.
TODOs
For draft pull requests please include a list of what needs to be done and check
off items as you complete them.