Remove jk #9
Merged
Remove jk #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
R2g. |
jwaldrop107
approved these changes
Feb 18, 2025
Member
|
🚀 [bumpr] Bumped! New version:v0.0.8 Changes:v0.0.7...v0.0.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
No.
Description
J and K were moved to Integrals, this PR removes them from SCF. I tried to get the Fock builder part of the
SCFIntegralDriverto work, but some reason the Fock matrix I get back is different even though it's just calling the same module. I don't want to debug that right now.TODOs
None if it passes CI.