Actually checks for convergence #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwaldrop107
requested changes
Mar 11, 2025
Co-authored-by: Jonathan M. Waldrop <[email protected]>
Co-authored-by: Jonathan M. Waldrop <[email protected]>
jwaldrop107
approved these changes
Mar 11, 2025
Member
|
🚀 [bumpr] Bumped! New version:v0.0.10 Changes:v0.0.9...v0.0.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
No.
Description
It's not pretty, but the SCF Loop module will now check for SCF convergence (instead of just running for a set number of iterations). This PR is meant as a quick fix and adds tech debt to the code (convergence should really be done with a module so it can be better controlled. This PR also shows that TW really needs some QoL improvements.
TODOs
None. R2g.