Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
c4726e3
Start of adding mermaid graphs
jlheflin Dec 27, 2024
ce04f9f
Restart addition of mermaid graph, test with hello_world function
jlheflin Dec 27, 2024
d00bdb7
Trying to add tests for mermaid.cpp
jlheflin Dec 27, 2024
7259026
just like me, ctest keeps failing
jlheflin Dec 29, 2024
0d6659f
Committing clang-format changes
github-actions[bot] Dec 29, 2024
203a8c8
Update mermaid.cpp
ryanmrichard Dec 29, 2024
b08bf98
Update mermaid.cpp
ryanmrichard Dec 29, 2024
6e720d1
Committing clang-format changes
github-actions[bot] Dec 29, 2024
09fb829
Finally actually doing some code
jlheflin Jan 9, 2025
4a419c9
Committing clang-format changes
github-actions[bot] Jan 9, 2025
372538f
Made suggested changes regarding mermaid.cpp, mermaid.hpp and the tes…
jlheflin Jan 9, 2025
ee6fdd4
Made changes with usage of decltype
jlheflin Jan 9, 2025
f61012b
Preparing to add module with several nested modules
jlheflin Jan 10, 2025
29fe47e
Committing clang-format changes
github-actions[bot] Jan 10, 2025
98746b2
loaded test modules into mm
jlheflin Jan 14, 2025
c4ad8dd
Committing clang-format changes
github-actions[bot] Jan 14, 2025
0177e4f
adjusted code to work since it didn't in the previous commit
jlheflin Jan 14, 2025
ff92d0c
Lego'd the modules, compiled normally?
jlheflin Jan 16, 2025
a06ae22
added some debug printout
jlheflin Jan 16, 2025
fca1de6
Committing clang-format changes
github-actions[bot] Jan 16, 2025
af6a531
Added submodule printing function, adjusted module creation
jlheflin Jan 23, 2025
953195f
Added submodule printing function, adjusted module creation
jlheflin Jan 23, 2025
40d249e
In git commit purgatory, making sure I didn't kill anything
jlheflin Jan 23, 2025
5125681
Committing clang-format changes
github-actions[bot] Jan 23, 2025
8c9a575
Really close now
jlheflin Jan 23, 2025
8afb7a8
Committing clang-format changes
github-actions[bot] Jan 23, 2025
015c5af
I am really hating these clang-formats
jlheflin Jan 23, 2025
7e07b3b
Committing clang-format changes
github-actions[bot] Jan 23, 2025
5e5a879
Learned how to deal with missing submodules
jlheflin Jan 24, 2025
6a21485
Committing clang-format changes
github-actions[bot] Jan 24, 2025
7eac1b7
removed some debugging statements and learned clang-format
jlheflin Jan 24, 2025
2d30468
reflowed the files a bit
jlheflin Jan 24, 2025
1a26759
commiting clang-format changes, by myself
jlheflin Jan 24, 2025
ccb47bb
adding changes
jlheflin Jan 25, 2025
2c295a7
if my brain was a stringstream
jlheflin Jan 25, 2025
86a440d
I have an indent in my head
jlheflin Jan 26, 2025
db6470d
I am now a stringstream master (I only know ss.str())
jlheflin Jan 26, 2025
cc0e230
removed indent for modules, not needed
jlheflin Jan 27, 2025
75e9a42
function is now recursive
jlheflin Jan 28, 2025
1bb7e5a
bargain-bin GhostFragment test added
jlheflin Jan 30, 2025
8951fd1
commiting clang-format changes, but this time with more pizzazz
jlheflin Jan 30, 2025
3f3fbc6
removed multi-line comments
jlheflin Jan 30, 2025
9b5d8ab
started conversion to mermaid graph output
jlheflin Jan 30, 2025
9569cbc
clang-format, but with less pizzazz
jlheflin Jan 30, 2025
74bdff6
fixed the letter issue
jlheflin Feb 6, 2025
e373ecf
adjusted src mermaid.cpp to better follow the mermaid style
jlheflin Feb 13, 2025
1748a54
Committing clang-format changes
github-actions[bot] Feb 13, 2025
31ab2f1
Functional Mermaid Graph now implemented in mermaid.cpp
jlheflin Feb 17, 2025
2f33e42
Committing clang-format changes
github-actions[bot] Feb 17, 2025
85be342
Adjusted tests to unit tests instead of an integration test
jlheflin Mar 13, 2025
2cd6ca0
Committing clang-format changes
github-actions[bot] Mar 13, 2025
530d9c6
Merge branch 'master' into mermaid-graph
jlheflin Mar 13, 2025
d611a1c
Apply suggestions from code review
ryanmrichard Mar 13, 2025
3f712ee
remove ss.str() printing
jlheflin Mar 14, 2025
01208fa
unpdate include path
jlheflin Mar 14, 2025
fa74221
Committing clang-format changes
github-actions[bot] Mar 14, 2025
1574ef4
added functions to pluginplay::printing namespace
jlheflin Mar 14, 2025
4de393d
fixed letter code issue
jlheflin Mar 14, 2025
4150c25
adjusted letter generation code
jlheflin Mar 14, 2025
423a6ba
Update src/pluginplay/printing/mermaid.cpp
ryanmrichard Mar 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
# These are directories used by IDEs for storing settings
.idea/
.vscode/
.cache

# These are common Python virtual enviornment directory names
venv/
Expand Down
3 changes: 2 additions & 1 deletion include/pluginplay/printing/mermaid.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/

#pragma once
#include "module_manager/module_manager_class.hpp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include "module_manager/module_manager_class.hpp"
#include <pluginplay/module_manager/module_manager_class.hpp>

Long story short, if a header file lives in the include/ directory you should include it with angle brackets (and start the path with the directory which follows include/ in the path, which in this case is pluginplay)

#include <string>

std::string hello_world();
std::string hello_world(const pluginplay::ModuleManager& mm);
10 changes: 8 additions & 2 deletions src/pluginplay/printing/mermaid.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@
* limitations under the License.
*/

#include "module_manager/module_manager_class.hpp"
#include <pluginplay/printing/mermaid.hpp>
#include <string>
#include <pluginplay/pluginplay.hpp>

std::string hello_world() { return "Hello World!"; }
std::string hello_world(const pluginplay::ModuleManager& mm) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at some point you're going to need to change the name of this function to something more descriptive (like call_graph_to_mermaid_graph or something)

for (int i = 0; i < mm.size(); i++) {
std::cout << "There are at least some modules in here" << std::endl;
}
return "Hello World!";
}
10 changes: 9 additions & 1 deletion tests/cxx/unit_tests/pluginplay/printing/mermaid.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,19 @@

#include "../catch.hpp"
#include "../test_common.hpp"
#include "module_manager/module_manager_class.hpp"
#include <pluginplay/printing/mermaid.hpp>
#include <pluginplay/module_manager/module_manager.hpp>


TEST_CASE("hello_world") {
pluginplay::ModuleManager mm;

SECTION("huh") {
auto hello = hello_world();
using mod_t = testing::NoPTModule;
mm.add_module<mod_t>("A mod");
auto hello = hello_world(mm);
std::cout << "Bro the test ran but idk if the internals ran" << std::endl;
REQUIRE(hello == "Hello World!");
}
}
Loading