-
Notifications
You must be signed in to change notification settings - Fork 1
Python Packaging #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python Packaging #30
Conversation
Co-authored-by: Zachery Crandall <[email protected]>
|
@ryanmrichard and @zachcran, this has morphed into a larger refactor than I originally intended. I've tried to update the code to differentiate between the interfaces (ASE and MolSSI) and backends (just NWChem for now), and to behave according to which combinations are available. |
zachcran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good. The most important suggestions are for the testing strategy, but I also came across a few nits to pick at in the other files. Feel free to ignore some of these suggestions, but please reply saying so and don't resolve the thread. Otherwise it can be really hard to find them again sometimes or it might seem like you missed it!
For a few of the comments, I may not have pointed every instance of the issue, so make sure to do a once-over checking for it elsewhere if it seems like something that might pop up in other places.
zachcran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is this pull request associated with an issue(s)?
No.
Description
The PR makes changes to move towards packaging FriendZone as an explicit python library by adding the
pyproject.tomland related updates to.gitignore.Changes are also made to the CMake build and the
friends.pymodule to check for Python dependencies in a more Pythonic fashion.