Skip to content

Conversation

@ryanmrichard
Copy link
Member

@ryanmrichard ryanmrichard commented Sep 26, 2024

Is this pull request associated with an issue(s)?
This PR is an alternative to #14.

Description
This PR attempts to address the same issues as #14; however, it does so with a reduced reliance
on module-specific inputs (at least user-facing module-specific inputs). Specific changes:

  • Gradients are enabled
  • Can now swap packages through a module-specific input.
  • Minimal code duplication in implementing the gradient module vs. the energy module.

TODOs

  • I still want to get the MPI configuration passed to QCEngine correctly.

@ryanmrichard
Copy link
Member Author

@jlheflin and @fcuantico I tagged you as reviewers primarily so you could follow the PR process. You're also welcome to leave feedback on the code if you want.

@ryanmrichard ryanmrichard marked this pull request as ready for review September 27, 2024 15:17
@ryanmrichard
Copy link
Member Author

This is r2g now.

@ryanmrichard
Copy link
Member Author

(Disclaimer I make no guarantees that the MPI forwarding to QCEngine actually runs in parallel)

Copy link
Member

@jwaldrop107 jwaldrop107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanmrichard ryanmrichard merged commit 747b030 into master Sep 27, 2024
@ryanmrichard ryanmrichard deleted the qcengine_support branch September 27, 2024 15:41
@jwaldrop107
Copy link
Member

🚀 [bumpr] Bumped! New version:v1.0.7 Changes:v1.0.6...v1.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants