Allow enable-cuda-compat hook to be disabled in CDI spec generation #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
allow-hooks-disable
branch
from
3bf1a8b to
7dc7e69
Compare
elezar
added
the
must-backport
elezar
force-pushed
the
allow-hooks-disable
branch
from
7dc7e69 to
5785120
Compare
ArangoGutierrez
approved these changes
Mar 7, 2025
| const ( | ||
| // HookEnableCudaCompat refers to the hook used to enable CUDA Forward Compatibility. | ||
| // This was added with v1.17.5 of the NVIDIA Container Toolkit. | ||
| HookEnableCudaCompat = HookName("enable-cuda-compat") |
There was a problem hiding this comment.
Not a blocker, but we should have as TODO to have a central place to define this internal names to make it easier to edit/change a hook name in the future.
There was a problem hiding this comment.
Yes, we should refactor the hook handling to have them defined more consistently. Some of this falls in the scope of pulling the CDI spec generation into go-nvlib instead of implementing it here in the NVIDIA Container Toolkit. This would also mean that the device plugin and the dra driver do not need to depend on the nvidia-container-toolkit.
This change adds support to the nvcdi package to opt out of specific hooks. Currently only the `enable-cuda-compat` hook is supported. This allows clients to generate a CDI spec that is compatible with older nvidia-cdi-hook CLIs. Signed-off-by: Evan Lezar <[email protected]>
Management containers don't generally need forward compatibility. We disable the enable-cuda-compat hook to not include this in the generated CDI specifications. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
allow-hooks-disable
branch
from
5785120 to
0f299c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support to the nvcdi package to opt out of specific hooks.
Currently only the
enable-cuda-compathook is supported. This allows clients to generate a CDI spec that is compatible with older nvidia-cdi-hook CLIs.This is required in cases where a tool such as the k8s-device-plugin or k8s-dra-driver-gpu needs to generate a CDI specification for a version of the NVIDIA Container Toolkit that does not support this hook.