bump default DOCKER ARG default golang version to 1.22.8 #136
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The version of Golang being used during build is actually 1.23.2: https://github.com/NVIDIA/mig-parted/actions/runs/11350079065/job/31567676999#step:7:20 which is defined here: https://github.com/NVIDIA/mig-parted/blob/main/deployments/devel/Dockerfile#L17 |
|
Yes, I am waiting till 1.23.3 is released as it has the fixes for when running in a docker arm64 container |
|
I think it's good to atleast bump this default even though the actual golang version is |
|
The commit message is misleading since you are not actually changing the version of Go used to build this project. |
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
tariq1890
changed the title
|
Please check now |
cdesiniotis
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.