Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Nemo Eval service #278

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Adding Nemo Eval service #278

merged 3 commits into from
Jan 16, 2025

Conversation

visheshtanksale
Copy link
Collaborator

No description provided.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 8, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@visheshtanksale visheshtanksale force-pushed the nemo-eval branch 2 times, most recently from 6dea733 to 06e60e8 Compare January 8, 2025 18:55
shivamerla
shivamerla reviewed Jan 9, 2025
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
shivamerla
shivamerla reviewed Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@shivamerla shivamerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! Lets address the API changes and we can get this merged.

shivamerla
shivamerla previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@shivamerla shivamerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@visheshtanksale visheshtanksale enabled auto-merge (squash) January 16, 2025 00:06
@visheshtanksale
Adding Nemo Eval service
a4f7156 
Signed-off-by: Vishesh Tanksale <[email protected]>
@visheshtanksale
Addressing review comments
c45a2d2 
Signed-off-by: Vishesh Tanksale <[email protected]>
@visheshtanksale
Resolving merge issues
ba2df87 
Signed-off-by: Vishesh Tanksale <[email protected]>
@shivamerla shivamerla self-requested a review January 16, 2025 00:28
@visheshtanksale visheshtanksale merged commit 94d323f into NVIDIA:main Jan 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivamerla shivamerla shivamerla approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez ArangoGutierrez is a code owner

@slu2011 slu2011 Awaiting requested review from slu2011 slu2011 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@visheshtanksale @shivamerla