Cleanup in prep for structured params #89
Conversation
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
| @@ -0,0 +1,19 @@ | |||
| /* | |||
| * Copyright (c) 2023, NVIDIA CORPORATION. All rights reserved. | |||
There was a problem hiding this comment.
General question. What is a consistent year for these headers?
There was a problem hiding this comment.
Yeah, not sure. This is obviously a copy and paste job ...
There was a problem hiding this comment.
Not a blocker for this PR. More a general question for follow-up.
| @@ -14,7 +14,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| package v1alpha1 | |||
| package sharing | |||
There was a problem hiding this comment.
So these utils are no longer versioned? Is that because we don't expect them to be public?
There was a problem hiding this comment.
Hmm, you're right. They are in fact public, which is why they should probably be versioned....
There was a problem hiding this comment.
I take it back -- the apis that use this are still versioned, so as long as we only change this in conjunction with a bump on those API versions, we are OK.
| @@ -167,6 +175,8 @@ func (l deviceLib) getGpuInfo(index int, device nvdev.Device) (*GpuInfo, error) | |||
| brand: brand, | |||
| architecture: architecture, | |||
| cudaComputeCapability: cudaComputeCapability, | |||
| driverVersion: driverVersion, | |||
| cudaDriverVersion: fmt.Sprintf("%v.%v", cudaDriverVersion/1000, (cudaDriverVersion%1000)/10), | |||
There was a problem hiding this comment.
Out of scope for this PR. But do we want to pull this into gonvlib (GetCUDADriverVersionString or something?)
There was a problem hiding this comment.
Let#s do it as a follow-up
No description provided.