-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and clean up the quickstart README file #112
Open
yuanchen8911
wants to merge
1
commit into
NVIDIA:main
Choose a base branch
from
yuanchen8911:readme
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
#### Show the current MIG configuration of the machine | ||
```console | ||
nvidia-smi --query-gpu=index,name,uuid,mig.mode.current --format=csv | ||
nvidia-smi -L | ||
``` | ||
|
||
#### Show current state of the cluster | ||
```console | ||
kubectl get pod -A | ||
``` | ||
|
||
#### Show the yaml files for MIG example apps: | ||
```console | ||
vim -O gpu-test4.yaml gpu-test5.yaml gpu-test6.yaml | ||
``` | ||
|
||
#### Deploy the 3 MIG example apps above: | ||
```console | ||
kubectl apply --filename=gpu-test{4,5,6}.yaml | ||
``` | ||
|
||
#### Show all the pods starting up: | ||
```console | ||
kubectl get pod -A -l app=pod | ||
``` | ||
|
||
#### Show the output of nvidia-smi: | ||
```console | ||
nvidia-smi -L | ||
``` | ||
|
||
#### Show the MIG devices allocated to each pod in gpu-test4 | ||
```console | ||
for pod in \ | ||
$(kubectl get pod \ | ||
-n gpu-test4 \ | ||
--output=jsonpath='{.items[*].metadata.name}'); \ | ||
do \ | ||
echo "${pod}:" | ||
kubectl logs -n gpu-test4 ${pod} -c ctr0 | ||
kubectl logs -n gpu-test4 ${pod} -c ctr1 | ||
kubectl logs -n gpu-test4 ${pod} -c ctr2 | ||
kubectl logs -n gpu-test4 ${pod} -c ctr3 | ||
echo "" | ||
done | ||
``` | ||
|
||
#### Delete this MIG examples: | ||
```console | ||
kubectl delete --filename=gpu-test{4,5,6}.yaml | ||
``` | ||
|
||
#### Show the pods terminating: | ||
```console | ||
kubectl get pods -A -l app=pod | ||
``` | ||
|
||
#### Show the output of nvidia-smi | ||
```console | ||
nvidia-smi -L | ||
``` |
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting -- I though I had purposfully removed demo 4 from this READMe for exactly this reason. Maybe I only did it here, but not in our actual driver repo: https://github.com/kubernetes-sigs/dra-example-driver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah -- I see now. This is the file down in the quickstart folder -- yeah, this was just copied from my demo script when I presented this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that
test-4 (MIG demo)
is different from the other three. We also describe test-4 separately in detail later. I think the descriptions would be clearer if we separated them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to update this to only include examples that can be run on any GPU and separate out the MIG use cases to another folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, test-5/6 are MIG examples too. We didn't even describe them in README. Let me update the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a new folder
mig
and moved the MIG example gpu-test4/5/6 to it and updated README files accordingly.