Update logic to set environment for calls out to nvidia-smi #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
reviewed
May 7, 2024
cmd/nvidia-dra-plugin/nvlib.go
Outdated
| @@ -495,11 +511,19 @@ func (l deviceLib) setTimeSlice(uuids []string, timeSlice int) error { | |||
| } | |||
|
|
|||
| func (l deviceLib) setComputeMode(uuids []string, mode string) error { | |||
| // In order for nvidia-smi to run, we need to set the PATH to the parent of | |||
There was a problem hiding this comment.
Does it make sense to add a runNvidiaSMI method to encapsulate this logic?
There was a problem hiding this comment.
i thought about it, but purposefully didn't since there are only 2 instances of this call and we want to drop the second one soon.
|
Just tested this before merging and it doesn't seem to work: |
|
I think wrapping the call in a "bash -c" would likely work. |
klueska
force-pushed
the
fix-mps-mounting
branch
2 times, most recently
from
f44f0ba to
b338e30
Compare
Previously, we were setting the envvars needed for nvidia-smi in the plugin's environment itself. This caused errors, however, when shelling out to other binaries that didn't need these envvars set. This change pushes the setting of the envvars into the actual exec call for nvidia-smi instead of setting them in the plugin's environment itself. Closes NVIDIA#106 Signed-off-by: Kevin Klues <[email protected]>
elezar
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were setting the envvars needed for nvidia-smi in the plugin's environment itself. This caused errors, however, when shelling out to other binaries that didn't need these envvars set.
This change pushes the setting of the envvars into the actual exec call for nvidia-smi instead of setting them in the plugin's environment itself.
Closes #106