Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert gpu driver util commits #193

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Revert gpu driver util commits #193

merged 4 commits into from
Jan 17, 2025

Conversation

tariq1890
Copy link
Contributor

No description provided.

@tariq1890 tariq1890 requested a review from cdesiniotis January 17, 2025 01:23
@cdesiniotis
Copy link
Contributor

We are reverting all of these commits because when we re-introduce the auto-detection, we will use the nvidia-installer rather than our own gpu-driver-util, right?

@tariq1890
Copy link
Contributor Author

tariq1890 commented Jan 17, 2025 •
edited
Loading

We are reverting all of these commits because when we re-introduce the auto-detection, we will use the nvidia-installer rather than our own gpu-driver-util, right?

Correct, that is the plan

UPDATE: we will not be bringing back gpu-driver-util. So we are not restoring these commits

@tariq1890 tariq1890 marked this pull request as ready for review January 17, 2025 21:32
@tariq1890 tariq1890 merged commit 0d12112 into main Jan 17, 2025
8 checks passed
@tariq1890 tariq1890 deleted the revert-gpu-driver-util-commits branch January 17, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdesiniotis cdesiniotis cdesiniotis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tariq1890 @cdesiniotis