-
Notifications
You must be signed in to change notification settings - Fork 679
Moving current docs to Pydata [issue #1390] #1408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTML files should never be committed here. The .gitignore should explicitly exclude these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a miss in the changes as using the prior make command these files would have been at docs/source/html which is properly excluded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jmartin-tech would it help if I make the changes for .gitignore in this PR or should I create an issue and submit another PR for that?
I've also mentioned that there was a bug in the _ext files when I started this change, it was an easy fix and I could also help with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs build should not place files outside the docs folder, please adjust any build process changes to ensure the path for artifacts stays docs/source/html which is already registered as excluded in .gitignore.
I suspect the build location difference was simply due to how you are invoking the build process. The docs/README.md notes usage of the command make -C docs/source doc when building from the root of the repo. If you used some other command please validate that documented pattern is still valid and does not leave generated files in locations not already accounted for.
As far as the _ext files question, no context on what was found has been provided, if added here please document what what the issue was why it needed to be addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for clarifying. I have removed the wrongly placed html files and included the fixed garak_ext file.
to provide more context on the _ext file, the small bug was due to the use of double and single quotation marks in the fstring, line 28.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great spot on the quotation syntax.
Please consider a rebase and squash to keep the files add and removes from living on in the git history.
Once this is promoted from draft a full review of the impacts will be done.
docs/source/conf.py
Outdated
| #html_css_files = [ | ||
| # "css/garak_theme.css", | ||
| #] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove if this is no-longer valid, however we definitely still want the css theme to be usable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will work on that, it broke when the theme changed
d753147 to
e38a637
Compare
|
Hi @jmartin-tech, commits have been squashed..I believe this is finally ready for review. ps: this may also fix issue #1405 quickly in the future |
Addresses issue #1390
Verification
List the steps needed to make sure this thing works
{ "huggingface": { "torch_type": "float32" } }garak -m <model_type> -n <model_name>python -m pytest tests/If you are opening a PR for a new plugin that targets a specific piece of hardware or requires a complex or hard-to-find testing environment, we recommend that you send us as much detail as possible.
Specific Hardware Examples:
cuda/mps( Please notcudaviaROCmif related )Complex Software Examples: