Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for latest ollama support #1092

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

jmartin-tech
Copy link
Collaborator

The latest ollama package changed the error raised from httpx to OSError.

To provide early detection of similar issues a workflow triggering pytest and package testing is also added.

  • set new minimum version for ollama > 0.4.7
  • update error handler in test
  • add nightly pytest & package test workflow

Adding workflow_call to existing workflows allows the new workflow to reuse them.

For now the action results will need to be reviewed periodically, notifications for failures can be added in the future.

The latest ollama package changed the error raised from httpx to OSError
* set new minimum version for ollama > 0.4.7
* update error handler in test
Copy link
Collaborator

@erickgalinkin erickgalinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jmartin-tech jmartin-tech merged commit 9ce6716 into NVIDIA:main Jan 30, 2025
9 checks passed
@jmartin-tech jmartin-tech deleted the fix/dependency-check branch January 30, 2025 15:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants