Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added generator for OpenRouter.ai #1051
base: main
Are you sure you want to change the base?
Added generator for OpenRouter.ai #1051
Changes from 4 commits
ca3ec2e
c6d670c
f70241e
78bb00f
2d38ced
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is not needed, the api_key handling and is build into the base class and
ENV_VAR
set above, and theuri
value should be set viaDEFAULT_PARAMS
noted in another comment.Code for
_load_client()
seems incomplete as there is no detection of chat vs completion for settingself.generator
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again code that is not needed, this adds a large amount of noise to the logs and is less comprehensive in handling chat vs completion than the default
_call_model()
implementation fromOpenAICompatible
.