-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct argument in TAP #1022
Conversation
DCO Assistant Lite bot All contributors have signed the DCO ✍️ ✅ |
Thanks! Will take a look Is there a test that could have caught this? |
@harshraj172 could you sign the DCO please |
Sorry for the late reply. Do you want me to write a test which can catch this? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class impacted here does not currently have any tests in place, if coverage were added it could have caught this.
@harshraj172, we can accept this without an added unit test however you will need to complete the DCO signing process for us to be able to credit you for the change. Please add the comment requested by the bot and the trigger recheck
comment to complete the signature.
I have read the DCO Document and I hereby sign the DCO |
recheck |
I have read the DCO Document and I hereby sign the DCO |
recheck |
Fix incorrect configuration variable in
garak/resources/tap/tap_main.py
Fix
This PR addresses a bug in garak/resources/tap/tap_main.py where the incorrect variable name was used for the evaluator model configuration. Specifically, the line:
was corrected to:
This fix ensures that the proper model configuration is being used when initializing the evaluator.