Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probe: add Arabic donotanswer #1016

Closed
wants to merge 1 commit into from
Closed

Conversation

Eaalghamdi
Copy link

@Eaalghamdi Eaalghamdi commented Nov 20, 2024

I added Arabic translation of all donotanswer probes which were quality checked by human to ensure suitability to the Arabic language, added Arabic detector for the probe. The new probes and detectors passed the test during development.

Signed-off-by: Emad Alghamdi <[email protected]>
Copy link
Contributor

DCO Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by just posting a Pull Request Comment same as the below format.


I have read the DCO Document and I hereby sign the DCO


You can retrigger this bot by commenting recheck in this Pull Request

@Eaalghamdi
Copy link
Author

I have read the DCO Document and I hereby sign the DCO

@Eaalghamdi Eaalghamdi changed the title probe: add Arabic DNA probe: add Arabic donotanswer Nov 20, 2024
@jmartin-tech jmartin-tech added the needs unique branch update with a unique branch name required label Nov 20, 2024
@jmartin-tech
Copy link
Collaborator

Thanks for your pull request! We require for all contributed code to come from a from a unique branch in your repository before it can be merged.

Please create a new branch in your fork of garak and resubmit this from that branch.

If you are using Git on the command line that may look like:

# Checkout the main branch
git checkout main

# Create a new branch for your feature
git checkout -b <BRANCH_NAME>

# Add your new files
git add plugins/my-cool-new-plugin

# Commit your changes with a relevant message
git commit

# Push your changes to GitHub
git push origin <BRANCH_NAME>

# Now browse to the following URL and create your pull request!
# - https://github.com/NVIDIA/garak/pulls

This helps protect the process, ensure users are aware of commits on the branch being considered for merge, allows for a location for more commits to be offered without mingling with other contributor changes and allows contributors to make progress while a PR is still being reviewed.

Please do resubmit from a unique branch, we greatly value your contribution! 🎉

@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs unique branch update with a unique branch name required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants