-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix huggingface inference endpoint name #1011
Conversation
the name provided during construction is populated by the call to `super().__init__()`, access to `self` attributes is required for any value populated by `Configurable`. Signed-off-by: Jeffrey Martin <[email protected]>
Signed-off-by: Jeffrey Martin <[email protected]>
Add validation test to ensure uri values and names populate as expected Signed-off-by: Jeffrey Martin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Did we test on an actual HF InferenceAPI just to be sure it works as intended? If not, I can spin one up tomorrow.
I tested the public endpoint referenced in the issue, I have not done an end to end test with a private endpoint. |
Tested the fix and works for what we've been trying out. Also I guess (and seemed to work, tho it's getting late)
in both would make it a bit more easy to follow, the self.name = name confused me when trying to figure the code out, as I thought it implies the super() won't do anything to it :-) |
@ppietikainen thanks for the extra testing, we have tried to add documentation on how Configurable classes config values are expected to be prioritized. The assignment of Also, in the different classes |
fix #998
the name provided during construction is populated by the call to
super().__init__()
, access toself
attributes is required for any value populated byConfigurable
.Verification
List the steps needed to make sure this thing works