fix: resolve SonarQube script injection and permission issues#41
Merged
Conversation
Move ${{ inputs.* }} from run blocks to env blocks to prevent GitHub
Actions script injection (S7630). Move workflow-level permissions to
job-level for least-privilege (S8264/S8233).
Resolves 16 BLOCKER + 2 MAJOR SonarQube findings.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lachen-nv
requested review from
abegnoche,
huaweic-nv and
mmou-nv
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${{ inputs.* }}fromrun:blocks toenv:blocks to prevent GitHub Actions script injection (SonarQube rule S7630)permissionsto job-level for least-privilege principle (SonarQube rules S8264/S8233)build-and-push-imagesjob retainspackages: write; all others getreadonlyResolves 16 BLOCKER + 2 MAJOR SonarQube findings across 4 files:
security-container-scan/action.ymlslack-notify/action.ymlpromote-image.ymlbuild-cds-containers.ymlNo breaking changes — action interfaces (inputs/outputs) are unchanged. Callers do not need to update.
Test plan
security-container-scanaction works in a workflow runslack-notifyaction sends messages correctlypromote-imageworkflow copies images between registriesbuild-cds-containersworkflow builds and pushes to GHCR🤖 Generated with Claude Code