fix: remove duplicate 'cds-' prefix in image names#17
Merged
Conversation
The matrix image names already contained 'cds-' prefix, and when combined with IMAGE_PREFIX='dsx-cds-', it resulted in double prefix: ❌ ghcr.io/nvidia/dsx-cds-cds-tools ❌ ghcr.io/nvidia/dsx-cds-cds-go-dev-1.24-alpine Changed matrix image names: - cds-tools → tools - cds-grafana-backup-tool → grafana-backup-tool - cds-go-dev-1.24-alpine → go-dev-1.24-alpine - cds-go-dev-1.24-debian → go-dev-1.24-debian Now produces correct image names: ✅ ghcr.io/nvidia/dsx-cds-tools ✅ ghcr.io/nvidia/dsx-cds-grafana-backup-tool ✅ ghcr.io/nvidia/dsx-cds-go-dev-1.24-alpine ✅ ghcr.io/nvidia/dsx-cds-go-dev-1.24-debian Fixes: https://github.com/NVIDIA/dsx-github-actions/actions/runs/21131015559 Signed-off-by: mmou <mmou@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Problem
Test jobs failed after merging PR #16 because of incorrect image names:
https://github.com/NVIDIA/dsx-github-actions/actions/runs/21131015559
What was pushed:
What test jobs tried to pull:
Result:
Error response from daemon: manifest unknown🔍 Root Cause
Matrix image names already contained
cds-prefix:name: cds-toolsname: cds-go-dev-1.24-alpineWhen combined with
IMAGE_PREFIX='dsx-cds-', it created double prefix:🔧 Changes
Removed
cds-prefix from matrix image names:cds-toolstoolscds-grafana-backup-toolgrafana-backup-toolcds-go-dev-1.24-alpinego-dev-1.24-alpinecds-go-dev-1.24-debiango-dev-1.24-debian✅ Expected Result
Correct image names:
ghcr.io/nvidia/dsx-cds-tools:0.0.1ghcr.io/nvidia/dsx-cds-grafana-backup-tool:0.0.1ghcr.io/nvidia/dsx-cds-go-dev-1.24-alpine:0.0.1ghcr.io/nvidia/dsx-cds-go-dev-1.24-debian:0.0.1Test jobs will successfully pull and test the images.