-
Notifications
You must be signed in to change notification settings - Fork 204
fix(java): use Maven mirror, remove unnecessary plugins, other CI-stability improvements #2253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
1e95a87
31b26cf
a79577c
c5060bb
0fbdc3b
a94f8c5
ddc3e61
b150a67
00e1d60
bf87dc8
cff50f8
879aba4
56e5507
01a6637
67d7633
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,8 +56,8 @@ | |
|
|
||
| <distributionManagement> | ||
| <snapshotRepository> | ||
| <id>ossrh</id> | ||
| <url>https://oss.sonatype.org/content/repositories/snapshots</url> | ||
| <id>central</id> | ||
| <url>https://central.sonatype.com/repository/maven-snapshots/</url> | ||
| </snapshotRepository> | ||
| </distributionManagement> | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This project doesn't distributed any snapshots... you'll only see releases at https://central.sonatype.com/artifact/com.nvidia.cuvs/cuvs-java/versions And it doesn't rely on downloading any snapshots of dependencies. So this configuration is totally unnecessary. As more evidence of that... it references a repo (https://oss.sonatype.org/) that doesn't even exist any more. $ curl -I https://oss.sonatype.org
HTTP/2 404
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
We are actualy shortly going to be deploying nightly snapshos. I know this doesn't change much in this PR (and we still need to ditch the oss.sonatype.org), but I want to point this out because we have several customers asking us to distriute snapshots (some of them cannot build our code).
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep makes sense, whatever configuration is needed can be added as part of the work of publishing snapshots. |
||
|
|
||
|
|
@@ -205,14 +205,13 @@ | |
| </executions> | ||
| </plugin> | ||
| <plugin> | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
It also will try to download and check any dependencies for any stage that have That's why the original build failures we saw mentioned this We can just remove this... the release process for curl \
-XPOST \
-F bundle=@com.nvidia.cuvs:cuvs-java:26.06.0.zip \
https://central.sonatype.com/api/v1/publisher/uploadAs described at https://central.sonatype.org/publish/publish-portal-api/#uploading-a-deployment-bundle (publishing code is private, but can link offline for reviewers) |
||
| <groupId>org.sonatype.plugins</groupId> | ||
| <artifactId>nexus-staging-maven-plugin</artifactId> | ||
| <version>1.6.7</version> | ||
| <groupId>org.sonatype.central</groupId> | ||
| <artifactId>central-publishing-maven-plugin</artifactId> | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seeing a similar error: https://github.com/rapidsai/cuvs/actions/runs/27970909678/job/82782494961?pr=2253 Makes me think that maybe there's something else happening here, like maybe an SSL error downloading stuff from one of the package repositories or something. Will try re-running with more verbose logs.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Debug logs show the real problem... the package repository is responding with 429s. We're getting rate-limited.
https://github.com/rapidsai/cuvs/actions/runs/27974250285/job/82792307295?pr=2253#step:13:5175 This would also explain why we OFTEN but not ALWAYS see this issue in We should probably keep the |
||
| <version>0.9.0</version> | ||
| <extensions>true</extensions> | ||
| <configuration> | ||
| <serverId>ossrh</serverId> | ||
| <nexusUrl>https://oss.sonatype.org/</nexusUrl> | ||
| <autoReleaseAfterClose>false</autoReleaseAfterClose> | ||
| <publishingServerId>central</publishingServerId> | ||
| <autoPublish>false</autoPublish> | ||
| </configuration> | ||
| </plugin> | ||
| <plugin> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suppose the deploy/distribute cuvs-java JARs do not depend on this part? If yes, good to remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, as of now we don't pull or publish snapshots.
As Corey pointed out in #2253 (comment) we may do that in the future, but for now this is unused.