Forward-merge release/26.06 into main#2098
Merged
Merged
Conversation
Resolves #2087 # What does this PR do? There is a race condition on the std::optional `!handle_.has_value()`. While thread 1 works on assigning handle with mmap, thread 2 can race through and try to assign it as well. However, during reassignment it causes destructor of thread 1 to be called which calls unmap, leading to a segfault. To solve this we use `std::once` so that other threads can't enter the critical section. `std::once` is non reentrant, so we need to also refactor from using recursion to a while loop. `std::once` is not movable, so we allocate it on the heap and use a unique_pointer to keep track of it instead. We need to ensure member variables of blob are movable since blob is used in a std::variant Authors: - Anupam (https://github.com/aamijar) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #2088
Contributor
Author
|
SUCCESS - forward-merge complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/26.06 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.