Require CMake 4.0#2078
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (19)
✅ Files skipped from review due to trivial changes (13)
🚧 Files skipped from review as they are similar to previous changes (6)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR updates the minimum required CMake from 3.30.4 to 4.0 across CMake files, conda environment YAMLs, conda build recipes, dependency manifests, Python build configs, and Docker build docs. ChangesCMake minimum version bump to 4.0
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (7)
python/libcuvs/pyproject.toml (1)
83-83:⚠️ Potential issue | 🔴 CriticalVerify CMake 4.0 availability before merging.
Same concern as in other files - this requires CMake 4.0 which may not be released yet. This will block Python package builds for libcuvs.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@python/libcuvs/pyproject.toml` at line 83, The pyproject.toml currently requires "cmake>=4.0" which may not be released; verify CMake 4.0 is actually available and, if not, change the dependency declaration in pyproject.toml (the "cmake>=4.0" spec) to a safe, released range (e.g. a minimum released version and an upper bound like "<4") or make CMake an optional/build-system-only requirement so Python package builds aren’t blocked; update the "cmake>=4.0" entry accordingly and ensure any related build scripts (wheel/sdist tooling) align with the new constraint.java/docker-build/Dockerfile (1)
31-31:⚠️ Potential issue | 🔴 CriticalVerify CMake 4.0 availability before merging.
The Dockerfile downloads CMake from GitHub releases (line 60). If CMake 4.0 hasn't been released, the
wgetcommand will fail with a 404 error, breaking the Docker image build.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@java/docker-build/Dockerfile` at line 31, The Dockerfile currently sets ARG CMAKE_VERSION=4.0 but later uses wget to pull that release from GitHub; if 4.0 doesn't exist the build will 404. Change this by either setting ARG CMAKE_VERSION to a known released version (e.g., a stable 3.x tag) or add a check before the wget download: use the ARG in the download URL and perform a HEAD request (curl -I or wget --spider) to verify the release exists and, on failure, emit a clear error and/or fall back to a default released version. Update the references to ARG CMAKE_VERSION and the wget download invocation so they use the same variable and include the existence check/fallback logic.examples/c/CMakeLists.txt (1)
7-7:⚠️ Potential issue | 🔴 CriticalVerify CMake 4.0 availability before merging.
Examples will fail to build if CMake 4.0 doesn't exist yet. Developers trying to build/run examples will encounter immediate failures.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@examples/c/CMakeLists.txt` at line 7, The project currently requires CMake 4.0 via the cmake_minimum_required(VERSION 4.0 FATAL_ERROR) line which may not be available to developers; update the requirement to a more commonly available baseline (e.g., change cmake_minimum_required to a widely supported version like 3.15) or implement a safe fallback/compatibility guard around cmake_minimum_required so examples still build on older CMake installations; modify the cmake_minimum_required invocation in CMakeLists.txt accordingly to avoid immediate build failures for users without CMake 4.0.python/cuvs/pyproject.toml (1)
109-109:⚠️ Potential issue | 🔴 CriticalVerify CMake 4.0 availability before merging.
This change requires CMake 4.0 for the rapids-build-backend. As noted in the review of
conda/recipes/libcuvs/conda_build_config.yaml, CMake 4.0 may not have been released yet. This will prevent Python package builds if the version doesn't exist.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@python/cuvs/pyproject.toml` at line 109, The dependency line "cmake>=4.0" must be verified for public availability before merging; if CMake 4.0 is not released, change the constraint in pyproject (replace "cmake>=4.0") to a safe, released range (for example "cmake>=3.27,<4" or the previous pinned version) and make the matching change in the conda/recipes/libcuvs/conda_build_config.yaml so both packaging systems remain consistent.java/internal/CMakeLists.txt (1)
8-8:⚠️ Potential issue | 🔴 CriticalVerify CMake 4.0 availability before merging.
This
cmake_minimum_requireddirective will cause builds to fail with any CMake version less than 4.0. If CMake 4.0 hasn't been released, developers cannot build this project.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@java/internal/CMakeLists.txt` at line 8, The CMake minimum requirement is set to an unreleased/too-new version via the directive cmake_minimum_required(VERSION 4.0 FATAL_ERROR); verify CMake 4.0 is actually available to all builders, and if it is not, change that line to a released, broadly-available version (e.g., cmake_minimum_required(VERSION 3.26 FATAL_ERROR) or another agreed-upon minimum) or remove FATAL_ERROR to soften failure; update the repository README/CI to document the required CMake version if you keep the higher requirement.cmake/RAPIDS.cmake (1)
11-11:⚠️ Potential issue | 🔴 CriticalVerify CMake 4.0 availability before merging.
This is the preferred entry point for rapids-cmake projects. Requiring CMake 4.0 here will block all downstream projects if the version doesn't exist yet.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cmake/RAPIDS.cmake` at line 11, The top-level cmake_minimum_required(VERSION 4.0 FATAL_ERROR) is too strict and will break downstream projects if CMake 4.0 isn't available; relax it by replacing that call with a more widely-available baseline (e.g., cmake_minimum_required(VERSION 3.25) or similar) and remove the FATAL_ERROR token so projects can still configure; update the single cmake_minimum_required invocation in RAPIDS.cmake accordingly and add a short comment explaining the chosen baseline.java/docker-build/README.md (1)
116-116:⚠️ Potential issue | 🔴 CriticalVerify CMake 4.0 availability.
Documentation reflects the Dockerfile change to CMake 4.0. If CMake 4.0 doesn't exist yet, this documentation will be incorrect.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@java/docker-build/README.md` at line 116, The README line stating "**CMake 4.0**: Build system generator" may be inaccurate if CMake 4.0 is not yet available; verify whether CMake 4.0 exists and is usable in our Dockerfile or build environment, and then update the README accordingly: if CMake 4.0 is available, keep the line and optionally add a version requirement note; if not, revert the text to the supported CMake version (e.g., CMake 3.x) or make it version-agnostic (e.g., "CMake >= X.Y") so the documentation matches the actual Dockerfile and build scripts.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@conda/environments/all_cuda-131_arch-aarch64.yaml`:
- Line 13: Replace the unavailable requirement "cmake>=4.0" with a constraint
that matches conda-forge packages (e.g., "cmake>=3.25.0,<4.0" or pin to
"cmake=3.25.0") so environment resolution won't fail; update the YAML entry
containing the literal "cmake>=4.0" to the new version constraint.
---
Duplicate comments:
In `@cmake/RAPIDS.cmake`:
- Line 11: The top-level cmake_minimum_required(VERSION 4.0 FATAL_ERROR) is too
strict and will break downstream projects if CMake 4.0 isn't available; relax it
by replacing that call with a more widely-available baseline (e.g.,
cmake_minimum_required(VERSION 3.25) or similar) and remove the FATAL_ERROR
token so projects can still configure; update the single cmake_minimum_required
invocation in RAPIDS.cmake accordingly and add a short comment explaining the
chosen baseline.
In `@examples/c/CMakeLists.txt`:
- Line 7: The project currently requires CMake 4.0 via the
cmake_minimum_required(VERSION 4.0 FATAL_ERROR) line which may not be available
to developers; update the requirement to a more commonly available baseline
(e.g., change cmake_minimum_required to a widely supported version like 3.15) or
implement a safe fallback/compatibility guard around cmake_minimum_required so
examples still build on older CMake installations; modify the
cmake_minimum_required invocation in CMakeLists.txt accordingly to avoid
immediate build failures for users without CMake 4.0.
In `@java/docker-build/Dockerfile`:
- Line 31: The Dockerfile currently sets ARG CMAKE_VERSION=4.0 but later uses
wget to pull that release from GitHub; if 4.0 doesn't exist the build will 404.
Change this by either setting ARG CMAKE_VERSION to a known released version
(e.g., a stable 3.x tag) or add a check before the wget download: use the ARG in
the download URL and perform a HEAD request (curl -I or wget --spider) to verify
the release exists and, on failure, emit a clear error and/or fall back to a
default released version. Update the references to ARG CMAKE_VERSION and the
wget download invocation so they use the same variable and include the existence
check/fallback logic.
In `@java/docker-build/README.md`:
- Line 116: The README line stating "**CMake 4.0**: Build system generator" may
be inaccurate if CMake 4.0 is not yet available; verify whether CMake 4.0 exists
and is usable in our Dockerfile or build environment, and then update the README
accordingly: if CMake 4.0 is available, keep the line and optionally add a
version requirement note; if not, revert the text to the supported CMake version
(e.g., CMake 3.x) or make it version-agnostic (e.g., "CMake >= X.Y") so the
documentation matches the actual Dockerfile and build scripts.
In `@java/internal/CMakeLists.txt`:
- Line 8: The CMake minimum requirement is set to an unreleased/too-new version
via the directive cmake_minimum_required(VERSION 4.0 FATAL_ERROR); verify CMake
4.0 is actually available to all builders, and if it is not, change that line to
a released, broadly-available version (e.g., cmake_minimum_required(VERSION 3.26
FATAL_ERROR) or another agreed-upon minimum) or remove FATAL_ERROR to soften
failure; update the repository README/CI to document the required CMake version
if you keep the higher requirement.
In `@python/cuvs/pyproject.toml`:
- Line 109: The dependency line "cmake>=4.0" must be verified for public
availability before merging; if CMake 4.0 is not released, change the constraint
in pyproject (replace "cmake>=4.0") to a safe, released range (for example
"cmake>=3.27,<4" or the previous pinned version) and make the matching change in
the conda/recipes/libcuvs/conda_build_config.yaml so both packaging systems
remain consistent.
In `@python/libcuvs/pyproject.toml`:
- Line 83: The pyproject.toml currently requires "cmake>=4.0" which may not be
released; verify CMake 4.0 is actually available and, if not, change the
dependency declaration in pyproject.toml (the "cmake>=4.0" spec) to a safe,
released range (e.g. a minimum released version and an upper bound like "<4") or
make CMake an optional/build-system-only requirement so Python package builds
aren’t blocked; update the "cmake>=4.0" entry accordingly and ensure any related
build scripts (wheel/sdist tooling) align with the new constraint.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6492a733-9e10-4bd9-abf7-5038ab942be4
📒 Files selected for processing (32)
c/CMakeLists.txtcmake/RAPIDS.cmakeconda/environments/all_cuda-129_arch-aarch64.yamlconda/environments/all_cuda-129_arch-x86_64.yamlconda/environments/all_cuda-131_arch-aarch64.yamlconda/environments/all_cuda-131_arch-x86_64.yamlconda/environments/bench_ann_cuda-129_arch-aarch64.yamlconda/environments/bench_ann_cuda-129_arch-x86_64.yamlconda/environments/bench_ann_cuda-131_arch-aarch64.yamlconda/environments/bench_ann_cuda-131_arch-x86_64.yamlconda/environments/go_cuda-129_arch-aarch64.yamlconda/environments/go_cuda-129_arch-x86_64.yamlconda/environments/go_cuda-131_arch-aarch64.yamlconda/environments/go_cuda-131_arch-x86_64.yamlconda/environments/rust_cuda-129_arch-aarch64.yamlconda/environments/rust_cuda-129_arch-x86_64.yamlconda/environments/rust_cuda-131_arch-aarch64.yamlconda/environments/rust_cuda-131_arch-x86_64.yamlconda/recipes/cuvs-bench-cpu/conda_build_config.yamlconda/recipes/cuvs/conda_build_config.yamlconda/recipes/libcuvs/conda_build_config.yamlcpp/CMakeLists.txtdependencies.yamlexamples/c/CMakeLists.txtexamples/cpp/CMakeLists.txtjava/docker-build/Dockerfilejava/docker-build/README.mdjava/internal/CMakeLists.txtpython/cuvs/CMakeLists.txtpython/cuvs/pyproject.tomlpython/libcuvs/CMakeLists.txtpython/libcuvs/pyproject.toml
18 tasks
robertmaynard
approved these changes
May 13, 2026
KyleFromNVIDIA
added
improvement
bdice
approved these changes
May 14, 2026
dantegd
approved these changes
May 14, 2026
Member
Author
|
/merge |
cjnolet
approved these changes
May 16, 2026
github-project-automation
Bot
moved this from In Progress
to Done
in Unstructured Data Processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: rapidsai/build-planning#277